-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor publication page validation #843
Merged
caendesilva
merged 230 commits into
publications-feature
from
refactor-publication-page-validation
Jan 20, 2023
Merged
Refactor publication page validation #843
caendesilva
merged 230 commits into
publications-feature
from
refactor-publication-page-validation
Jan 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3a467cb3abe0d7d78b3f966b17760acbb4f432ff.
Codecov Report
@@ Coverage Diff @@
## publications-feature #843 +/- ##
==========================================================
Coverage 100.00% 100.00%
+ Complexity 3190 1601 -1589
==========================================================
Files 346 174 -172
Lines 7920 3984 -3936
==========================================================
- Hits 7920 3984 -3936 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
caendesilva
force-pushed
the
refactor-publication-page-validation
branch
from
January 20, 2023 18:42
cfbc2f3
to
3461749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Refactors the publication page validator to match the publication type validator, both in underlying implementation (Laravel Validators) and presentation. The validation logic is now moved to an action, and the command is dedicated to (optionally) selecting which publication(s) to validate, and then displaying the validation results.
Before screenshot
After screenshot
After screenshot (With a warning + verbose output)
*The invalid field counter has been fixed since taking the screenshot