Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Do not hide documentation pages in subdirectories #868

Conversation

caendesilva
Copy link
Member

Fixes #867

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #868 (c550d22) into master (a4f47c6) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##              master      #868     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1245      2492   +1247     
=============================================
  Files            146       292    +146     
  Lines           3252      6504   +3252     
=============================================
+ Hits            3252      6504   +3252     
Impacted Files Coverage Δ
.../src/Framework/Factories/NavigationDataFactory.php 100.00% <100.00%> (ø)
...mework/Exceptions/UnsupportedPageTypeException.php 100.00% <0.00%> (ø)
...ramework/src/Console/Commands/RouteListCommand.php 100.00% <0.00%> (ø)
...ework/src/Console/Commands/BuildRssFeedCommand.php 100.00% <0.00%> (ø)
...rc/Framework/Services/YamlConfigurationService.php 100.00% <0.00%> (ø)
...ork/src/Foundation/Concerns/ForwardsHyperlinks.php 100.00% <0.00%> (ø)
...c/Framework/Actions/CreatesNewMarkdownPostFile.php 100.00% <0.00%> (ø)
...packages/framework/src/Pages/DocumentationPage.php 100.00% <0.00%> (ø)
...elop/packages/framework/src/Pages/MarkdownPost.php 100.00% <0.00%> (ø)
...rc/Framework/Concerns/InteractsWithDirectories.php 100.00% <0.00%> (ø)
... and 137 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review January 23, 2023 11:47
@what-the-diff
Copy link

what-the-diff bot commented Jan 23, 2023

  • The method makeHidden() was changed.
  • A new condition has been added to the if statement in line 95: ! $this->isInstanceOf(DocumentationPage::class) &&

@caendesilva caendesilva merged commit 3834c84 into master Jan 23, 2023
@caendesilva caendesilva deleted the fix-bug-in-upcoming-version-nested-documentation-sidebar-items-are-hidden branch January 23, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in upcoming version: Nested documentation sidebar items are hidden
1 participant