Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge validating command features into base command #891

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jan 30, 2023

This is part one of this refactor, where I'm moving the commands within this branch, next I'll cherry pick the changes to master. I'm also doing some refactoring to the actual command class while I'm at it.

Edit: See #892

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #891 (d1d695b) into publications-feature (9109367) will not change coverage.
The diff coverage is n/a.

❗ Current head d1d695b differs from pull request most recent head c27acf2. Consider uploading reports for the commit c27acf2 to get more accurate results

@@                   Coverage Diff                    @@
##             publications-feature      #891   +/-   ##
========================================================
  Coverage                  100.00%   100.00%           
  Complexity                   1615      1615           
========================================================
  Files                         174       174           
  Lines                        4010      4011    +1     
========================================================
+ Hits                         4010      4011    +1     
Impacted Files Coverage Δ
.../src/Console/Commands/RebuildStaticSiteCommand.php
...ackages/framework/src/Console/Concerns/Command.php
...es/publications/src/Commands/ValidatingCommand.php
...mework/src/Framework/Actions/StaticPageBuilder.php
...framework/src/Console/Commands/MakePageCommand.php
...c/Framework/Features/Navigation/NavigationData.php
...kages/framework/src/Markdown/MarkdownConverter.php
...ork/src/Framework/Concerns/TracksExecutionTime.php
packages/framework/src/Foundation/HydeKernel.php
...ework/src/Console/Commands/BuildSitemapCommand.php
... and 338 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva force-pushed the merge-validating-command-changes-into-base-command branch from ac92e9c to 4246db7 Compare January 30, 2023 19:56
@caendesilva caendesilva changed the title Merge validating command changes into base command Merge validating command features into base command Jan 30, 2023
@caendesilva caendesilva marked this pull request as ready for review January 30, 2023 21:35
@caendesilva caendesilva merged commit 89c2d32 into publications-feature Jan 30, 2023
@caendesilva caendesilva deleted the merge-validating-command-changes-into-base-command branch January 30, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants