-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge validating command features into base command #891
Merged
caendesilva
merged 28 commits into
publications-feature
from
merge-validating-command-changes-into-base-command
Jan 30, 2023
Merged
Merge validating command features into base command #891
caendesilva
merged 28 commits into
publications-feature
from
merge-validating-command-changes-into-base-command
Jan 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## publications-feature #891 +/- ##
========================================================
Coverage 100.00% 100.00%
Complexity 1615 1615
========================================================
Files 174 174
Lines 4010 4011 +1
========================================================
+ Hits 4010 4011 +1 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
caendesilva
force-pushed
the
merge-validating-command-changes-into-base-command
branch
from
January 30, 2023 19:56
ac92e9c
to
4246db7
Compare
This reverts commit 5806fc5.
caendesilva
changed the title
Merge validating command changes into base command
Merge validating command features into base command
Jan 30, 2023
caendesilva
deleted the
merge-validating-command-changes-into-base-command
branch
January 30, 2023 21:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part one of this refactor, where I'm moving the commands within this branch, next I'll cherry pick the changes to master. I'm also doing some refactoring to the actual command class while I'm at it.
Edit: See #892