Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JetBrains PhpStorm Attributes package to monorepo dev-dependencies #905

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

caendesilva
Copy link
Member

Adds https://github.com/JetBrains/phpstorm-attributes to the development dependencies for this monorepo. This will prevent us from getting undefined class errors from static analysis when using those attributes. This will not affect any of the downstream split packages.

@caendesilva caendesilva marked this pull request as ready for review February 1, 2023 20:14
@caendesilva caendesilva force-pushed the add-phpstorm-attributes-package-to-monorepo branch from b165633 to 94278b9 Compare February 1, 2023 20:15
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #905 (94278b9) into master (afab768) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##              master      #905     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1281      2562   +1281     
=============================================
  Files            147       294    +147     
  Lines           3354      6708   +3354     
=============================================
+ Hits            3354      6708   +3354     
Impacted Files Coverage Δ
...res/DataCollections/Facades/MarkdownCollection.php 100.00% <0.00%> (ø)
...ork/src/Foundation/Concerns/ForwardsFilesystem.php 100.00% <0.00%> (ø)
...ork/src/Framework/Features/Templates/Homepages.php 100.00% <0.00%> (ø)
...ures/BuildTasks/PostBuildTasks/GenerateSitemap.php 100.00% <0.00%> (ø)
...kages/framework/src/Markdown/MarkdownConverter.php 100.00% <0.00%> (ø)
...es/framework/src/Console/Commands/DebugCommand.php 100.00% <0.00%> (ø)
...evelop/packages/framework/src/Facades/Features.php 100.00% <0.00%> (ø)
...framework/src/Console/Commands/MakePageCommand.php 100.00% <0.00%> (ø)
...uildTasks/PostBuildTasks/GenerateBuildManifest.php 100.00% <0.00%> (ø)
...packages/framework/src/Pages/Concerns/HydePage.php 100.00% <0.00%> (ø)
... and 137 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva merged commit c8d60c0 into master Feb 1, 2023
@caendesilva caendesilva deleted the add-phpstorm-attributes-package-to-monorepo branch February 1, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant