Move internal data store for the site output directory to the HydeKernel #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-better-ide-support' into move-project-configuration-properties-to-the-hyde-kernel
…notations Makes use of #903
…roperties-to-the-hyde-kernel
…roperties-to-the-hyde-kernel
…roperties-to-the-hyde-kernel
See motivation in #906
caendesilva
force-pushed
the
move-project-configuration-properties-to-the-hyde-kernel
branch
from
ce3378e to
c211342
Compare
Codecov Report
@@ Coverage Diff @@
## hydekernel-refactors #906 +/- ##
========================================================
Coverage ? 100.00%
Complexity ? 1283
========================================================
Files ? 147
Lines ? 3358
Branches ? 0
========================================================
Hits ? 3358
Misses ? 0
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This reverts commit 2c519d5.
Benefit of not using static properties :)
…roperties-to-the-hyde-kernel
caendesilva
deleted the
move-project-configuration-properties-to-the-hyde-kernel
branch
caendesilva
added a commit
that referenced
this pull request
Feb 2, 2023
HydeKernel refactors: - Move internal data store for the site output directory to the HydeKernel #906 - Remove the $sourceRoot constructor parameter from the HydeKernel #907 - Add source root and output path to kernel array representation #908 - Rename HydeKernel property and accessors outputPath to outputDirectory #909
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable location determining which directory the site is compiled to is moved from the Site facade to the HydeKernel.
Thanks to the accessors added in #902, this doesn't mess with the API (not that anyone has had time to use the new methods in the two hours since, but still)
I did not move the normalization forcing relative paths, as anyone messing with the HydeKernel should know what they're doing, but I might port the warning that the directory will be emptied (though I should double check if we need it since I'm pretty sure we warn if the directory seems unsafe) Edit: yeah there's a warning so all good. No need to add extra warnings IMO.