Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change input string handler termination sequence to <<< #936

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Feb 8, 2023

Changes InputStreamHandler termination sequence from an empty line ('') to '<<<'.

While this is slightly more verbose, it prevents confusion and accidental premature termination as input strings might have empty lines. And the use case for entering paragraphs through the command line is (I assume) so slim that the extra characters are acceptable.

Fixes hydephp/publications#2 and resolves code review comment #685 (comment)

@caendesilva caendesilva linked an issue Feb 8, 2023 that may be closed by this pull request
@caendesilva caendesilva changed the base branch from master to publications-feature February 8, 2023 18:44
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #936 (cdf3b37) into publications-feature (a286237) will not change coverage.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##             publications-feature      #936     +/-   ##
==========================================================
  Coverage                  100.00%   100.00%             
+ Complexity                   3192      1597   -1595     
==========================================================
  Files                         348       174    -174     
  Lines                        7958      3981   -3977     
==========================================================
- Hits                         7958      3981   -3977     
Impacted Files Coverage Δ
...ations/src/Commands/Helpers/InputStreamHandler.php 100.00% <0.00%> (ø)
...ations/src/Commands/Helpers/InputStreamHandler.php
...blications/src/Commands/MakePublicationCommand.php
...work/src/Framework/Concerns/ValidatesExistence.php
packages/framework/src/Pages/DocumentationPage.php
...rk/src/Framework/Factories/BlogPostDataFactory.php
.../src/Framework/Factories/NavigationDataFactory.php
...src/Framework/Exceptions/FileNotFoundException.php
...k/src/Framework/Views/Components/LinkComponent.php
.../Framework/Features/Blogging/Models/PostAuthor.php
... and 165 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change input string handler termination sequence
1 participant