Merge pull request #616 from hydephp/skip-sitemap-generation-when-the…

…re-is-no-valid-base-url Skip sitemap generation when there is no valid base URL
hydephp · Apr 13, 2024 · d23128c · d23128c
2 parents 5788348 + 2221476
commit d23128c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/Framework/Actions/PostBuildTasks/GenerateSitemap.php b/src/Framework/Actions/PostBuildTasks/GenerateSitemap.php
@@ -21,6 +21,10 @@ class GenerateSitemap extends PostBuildTask
 
     public function handle(): void
     {
+        if (blank(Hyde::url()) || str_starts_with(Hyde::url(), 'http://localhost')) {
+            $this->skip('Cannot generate sitemap without a valid base URL');
+        }
+
         $this->path = Hyde::sitePath('sitemap.xml');
 
         $this->needsParentDirectory($this->path);

diff --git a/tests/Feature/Services/BuildTaskServiceTest.php b/tests/Feature/Services/BuildTaskServiceTest.php
@@ -30,6 +30,8 @@ class BuildTaskServiceTest extends TestCase
      */
     public function testBuildCommandCanRunBuildTasks()
     {
+        config(['hyde.url' => 'https://example.com']);
+
         $this->artisan('build')
             ->expectsOutputToContain('Removing all files from build directory')
             ->expectsOutputToContain('Generating sitemap')