Merge pull request #1796 from hydephp/improve-static-analysis

Internal: Improve test static analysis and improve tests hydephp/develop@254bbe7
hydephp · Jul 7, 2024 · ebb6022 · ebb6022
1 parent 1af0bd8
commit ebb6022
Show file tree

Hide file tree

Showing 10 changed files with 99 additions and 90 deletions.
diff --git a/tests/Feature/Services/Markdown/ShortcodeProcessorTest.php b/tests/Feature/Services/Markdown/ShortcodeProcessorTest.php
@@ -25,21 +25,22 @@ public function testDiscoveredShortcodesAreUsedToProcessInput()
     {
         $processor = new ShortcodeProcessor('>info foo');
 
-        $this->assertEquals('<blockquote class="info"><p>foo</p></blockquote>',
-            $processor->run());
+        $this->assertSame('<blockquote class="info"><p>foo</p></blockquote>', $processor->run());
     }
 
     public function testStringWithoutShortcodeIsNotModified()
     {
         $processor = new ShortcodeProcessor('foo');
 
-        $this->assertEquals('foo', $processor->run());
+        $this->assertSame('foo', $processor->run());
     }
 
     public function testProcessStaticShorthand()
     {
-        $this->assertEquals('<blockquote class="info"><p>foo</p></blockquote>',
-            ShortcodeProcessor::preprocess('>info foo'));
+        $this->assertSame(
+            '<blockquote class="info"><p>foo</p></blockquote>',
+            ShortcodeProcessor::preprocess('>info foo')
+        );
     }
 
     public function testShortcodesCanBeAddedToProcessor()
@@ -60,7 +61,7 @@ public static function resolve(string $input): string
         });
 
         $this->assertArrayHasKey('foo', $processor->getShortcodes());
-        $this->assertEquals('bar', $processor->run());
+        $this->assertSame('bar', $processor->run());
     }
 
     public function testShortcodesCanBeAddedToProcessorUsingArray()
@@ -81,6 +82,6 @@ public static function resolve(string $input): string
         }]);
 
         $this->assertArrayHasKey('foo', $processor->getShortcodes());
-        $this->assertEquals('bar', $processor->run());
+        $this->assertSame('bar', $processor->run());
     }
 }
diff --git a/tests/Feature/Services/RssFeedServiceTest.php b/tests/Feature/Services/RssFeedServiceTest.php
@@ -28,7 +28,7 @@ public function testServiceInstantiatesXmlElement()
     public function testXmlRootElementIsSetToRss20()
     {
         $service = new RssFeedGenerator();
-        $this->assertEquals('rss', $service->getXmlElement()->getName());
+        $this->assertSame('rss', $service->getXmlElement()->getName());
         $this->assertEquals('2.0', $service->getXmlElement()->attributes()->version);
     }
 

diff --git a/tests/Feature/Support/ProjectFileTest.php b/tests/Feature/Support/ProjectFileTest.php
@@ -21,19 +21,19 @@ public function testCanConstruct()
         $this->assertSame('foo', $file->path);
     }
 
-    public function can_make()
+    public function testCanMake()
     {
         $this->assertEquals(new ProjectFileTestClass('foo'), ProjectFileTestClass::make('foo'));
     }
 
     public function testCanConstructWithNestedPaths()
     {
-        $this->assertEquals('path/to/file.txt', ProjectFileTestClass::make('path/to/file.txt')->path);
+        $this->assertSame('path/to/file.txt', ProjectFileTestClass::make('path/to/file.txt')->path);
     }
 
     public function testAbsolutePathIsNormalizedToRelative()
     {
-        $this->assertEquals('foo', ProjectFileTestClass::make(Hyde::path('foo'))->path);
+        $this->assertSame('foo', ProjectFileTestClass::make(Hyde::path('foo'))->path);
     }
 
     public function testGetNameReturnsNameOfFile()

diff --git a/tests/Unit/Foundation/HyperlinkFileHelperRelativeLinkTest.php b/tests/Unit/Foundation/HyperlinkFileHelperRelativeLinkTest.php
@@ -31,126 +31,126 @@ protected function setUp(): void
 
     public function testHelperReturnsStringAsIsIfCurrentIsNotSet()
     {
-        $this->assertEquals('foo/bar.html', Hyde::relativeLink('foo/bar.html'));
+        $this->assertSame('foo/bar.html', Hyde::relativeLink('foo/bar.html'));
     }
 
     public function testHelperInjectsProperNumberOfDoublesSlash()
     {
         $this->mockCurrentPage('foo/bar.html');
-        $this->assertEquals('../foo.html', Hyde::relativeLink('foo.html'));
+        $this->assertSame('../foo.html', Hyde::relativeLink('foo.html'));
     }
 
     public function testHelperInjectsProperNumberOfDoublesSlashForDeeplyNestedPaths()
     {
         $this->mockCurrentPage('foo/bar/baz/qux.html');
-        $this->assertEquals('../../../foo.html', Hyde::relativeLink('foo.html'));
+        $this->assertSame('../../../foo.html', Hyde::relativeLink('foo.html'));
     }
 
     public function testHelperHandlesDestinationWithoutFileExtension()
     {
         $this->mockCurrentPage('foo/bar.html');
-        $this->assertEquals('../foo', Hyde::relativeLink('foo'));
+        $this->assertSame('../foo', Hyde::relativeLink('foo'));
     }
 
     public function testHelperHandlesCurrentWithoutFileExtension()
     {
         $this->mockCurrentPage('foo/bar');
-        $this->assertEquals('../foo.html', Hyde::relativeLink('foo.html'));
+        $this->assertSame('../foo.html', Hyde::relativeLink('foo.html'));
     }
 
     public function testHelperHandlesCaseWithoutAnyFileExtensions()
     {
         $this->mockCurrentPage('foo/bar');
-        $this->assertEquals('../foo', Hyde::relativeLink('foo'));
+        $this->assertSame('../foo', Hyde::relativeLink('foo'));
     }
 
     public function testHelperHandlesCaseWithMixedFileExtensions()
     {
         $this->mockCurrentPage('foo/bar.md');
-        $this->assertEquals('../foo.md', Hyde::relativeLink('foo.md'));
+        $this->assertSame('../foo.md', Hyde::relativeLink('foo.md'));
         $this->mockCurrentPage('foo/bar.txt');
-        $this->assertEquals('../foo.txt', Hyde::relativeLink('foo.txt'));
+        $this->assertSame('../foo.txt', Hyde::relativeLink('foo.txt'));
     }
 
     public function testHelperHandlesDifferentFileExtensions()
     {
         $this->mockCurrentPage('foo/bar');
-        $this->assertEquals('../foo.png', Hyde::relativeLink('foo.png'));
-        $this->assertEquals('../foo.css', Hyde::relativeLink('foo.css'));
-        $this->assertEquals('../foo.js', Hyde::relativeLink('foo.js'));
+        $this->assertSame('../foo.png', Hyde::relativeLink('foo.png'));
+        $this->assertSame('../foo.css', Hyde::relativeLink('foo.css'));
+        $this->assertSame('../foo.js', Hyde::relativeLink('foo.js'));
     }
 
     public function testHelperReturnsPrettyUrlIfEnabledAndDestinationIsAHtmlFile()
     {
         self::mockConfig(['hyde.pretty_urls' => true]);
         $this->mockCurrentPage('foo/bar.html');
-        $this->assertEquals('../foo', Hyde::relativeLink('foo.html'));
+        $this->assertSame('../foo', Hyde::relativeLink('foo.html'));
     }
 
     public function testHelperMethodDoesNotRequireCurrentPathToBeHtmlToUsePrettyUrls()
     {
         self::mockConfig(['hyde.pretty_urls' => true]);
         $this->mockCurrentPage('foo/bar');
-        $this->assertEquals('../foo', Hyde::relativeLink('foo.html'));
+        $this->assertSame('../foo', Hyde::relativeLink('foo.html'));
     }
 
     public function testHelperReturnsDoesNotReturnPrettyUrlIfWhenEnabledButAndDestinationIsNotAHtmlFile()
     {
         self::mockConfig(['hyde.pretty_urls' => true]);
         $this->mockCurrentPage('foo/bar.html');
-        $this->assertEquals('../foo.png', Hyde::relativeLink('foo.png'));
+        $this->assertSame('../foo.png', Hyde::relativeLink('foo.png'));
     }
 
     public function testHelperRewritesIndexWhenUsingPrettyUrls()
     {
         self::mockConfig(['hyde.pretty_urls' => true]);
         $this->mockCurrentPage('foo.html');
-        $this->assertEquals('./', Hyde::relativeLink('index.html'));
+        $this->assertSame('./', Hyde::relativeLink('index.html'));
         $this->mockCurrentPage('foo/bar.html');
-        $this->assertEquals('../', Hyde::relativeLink('index.html'));
+        $this->assertSame('../', Hyde::relativeLink('index.html'));
         $this->mockCurrentPage('foo/bar/baz.html');
-        $this->assertEquals('../../', Hyde::relativeLink('index.html'));
+        $this->assertSame('../../', Hyde::relativeLink('index.html'));
     }
 
     public function testHelperDoesNotRewriteIndexWhenNotUsingPrettyUrls()
     {
         self::mockConfig(['hyde.pretty_urls' => false]);
         $this->mockCurrentPage('foo.html');
-        $this->assertEquals('index.html', Hyde::relativeLink('index.html'));
+        $this->assertSame('index.html', Hyde::relativeLink('index.html'));
         $this->mockCurrentPage('foo/bar.html');
-        $this->assertEquals('../index.html', Hyde::relativeLink('index.html'));
+        $this->assertSame('../index.html', Hyde::relativeLink('index.html'));
         $this->mockCurrentPage('foo/bar/baz.html');
-        $this->assertEquals('../../index.html', Hyde::relativeLink('index.html'));
+        $this->assertSame('../../index.html', Hyde::relativeLink('index.html'));
     }
 
     public function testHelperRewritesDocumentationPageIndexWhenUsingPrettyUrls()
     {
         self::mockConfig(['hyde.pretty_urls' => true]);
         $this->mockCurrentPage('foo.html');
-        $this->assertEquals('docs/', Hyde::relativeLink('docs/index.html'));
+        $this->assertSame('docs/', Hyde::relativeLink('docs/index.html'));
         $this->mockCurrentPage('docs.html');
-        $this->assertEquals('docs/', Hyde::relativeLink('docs/index.html'));
+        $this->assertSame('docs/', Hyde::relativeLink('docs/index.html'));
         $this->mockCurrentPage('foo/bar.html');
-        $this->assertEquals('../docs/', Hyde::relativeLink('docs/index.html'));
+        $this->assertSame('../docs/', Hyde::relativeLink('docs/index.html'));
         $this->mockCurrentPage('docs/foo.html');
-        $this->assertEquals('../docs/', Hyde::relativeLink('docs/index.html'));
+        $this->assertSame('../docs/', Hyde::relativeLink('docs/index.html'));
     }
 
     public function testHelperDoesNotRewriteDocumentationPageIndexWhenNotUsingPrettyUrls()
     {
         self::mockConfig(['hyde.pretty_urls' => false]);
         $this->mockCurrentPage('foo.html');
-        $this->assertEquals('docs/index.html', Hyde::relativeLink('docs/index.html'));
+        $this->assertSame('docs/index.html', Hyde::relativeLink('docs/index.html'));
         $this->mockCurrentPage('docs.html');
-        $this->assertEquals('docs/index.html', Hyde::relativeLink('docs/index.html'));
+        $this->assertSame('docs/index.html', Hyde::relativeLink('docs/index.html'));
         $this->mockCurrentPage('foo/bar.html');
-        $this->assertEquals('../docs/index.html', Hyde::relativeLink('docs/index.html'));
+        $this->assertSame('../docs/index.html', Hyde::relativeLink('docs/index.html'));
         $this->mockCurrentPage('docs/foo.html');
-        $this->assertEquals('../docs/index.html', Hyde::relativeLink('docs/index.html'));
+        $this->assertSame('../docs/index.html', Hyde::relativeLink('docs/index.html'));
     }
 
     public function testHelperDoesNotRewriteAlreadyProcessedLinks()
     {
-        $this->assertEquals('../foo', Hyde::relativeLink('../foo'));
+        $this->assertSame('../foo', Hyde::relativeLink('../foo'));
     }
 }
diff --git a/tests/Unit/Foundation/HyperlinkFormatHtmlPathTest.php b/tests/Unit/Foundation/HyperlinkFormatHtmlPathTest.php
@@ -19,85 +19,85 @@ public function testHelperReturnsStringAsIsIfPrettyUrlsIsNotTrue()
     {
         self::mockConfig(['hyde.pretty_urls' => false]);
 
-        $this->assertEquals('foo/bar.html', Hyde::formatLink('foo/bar.html'));
+        $this->assertSame('foo/bar.html', Hyde::formatLink('foo/bar.html'));
     }
 
     public function testHelperReturnsPrettyUrlIfPrettyUrlsIsTrue()
     {
         self::mockConfig(['hyde.pretty_urls' => true]);
 
-        $this->assertEquals('foo/bar', Hyde::formatLink('foo/bar.html'));
+        $this->assertSame('foo/bar', Hyde::formatLink('foo/bar.html'));
     }
 
     public function testHelperRespectsAbsoluteUrls()
     {
         self::mockConfig(['hyde.pretty_urls' => false]);
-        $this->assertEquals('/foo/bar.html', Hyde::formatLink('/foo/bar.html'));
+        $this->assertSame('/foo/bar.html', Hyde::formatLink('/foo/bar.html'));
     }
 
     public function testHelperRespectsPrettyAbsoluteUrls()
     {
         self::mockConfig(['hyde.pretty_urls' => true]);
-        $this->assertEquals('/foo/bar', Hyde::formatLink('/foo/bar.html'));
+        $this->assertSame('/foo/bar', Hyde::formatLink('/foo/bar.html'));
     }
 
     public function testHelperRespectsRelativeUrls()
     {
         self::mockConfig(['hyde.pretty_urls' => false]);
-        $this->assertEquals('../foo/bar.html', Hyde::formatLink('../foo/bar.html'));
+        $this->assertSame('../foo/bar.html', Hyde::formatLink('../foo/bar.html'));
     }
 
     public function testHelperRespectsPrettyRelativeUrls()
     {
         self::mockConfig(['hyde.pretty_urls' => true]);
-        $this->assertEquals('../foo/bar', Hyde::formatLink('../foo/bar.html'));
+        $this->assertSame('../foo/bar', Hyde::formatLink('../foo/bar.html'));
     }
 
     public function testNonHtmlLinksAreNotModified()
     {
         self::mockConfig(['hyde.pretty_urls' => true]);
-        $this->assertEquals('/foo/bar.jpg', Hyde::formatLink('/foo/bar.jpg'));
+        $this->assertSame('/foo/bar.jpg', Hyde::formatLink('/foo/bar.jpg'));
     }
 
     public function testHelperRespectsAbsoluteUrlsWithPrettyUrlsEnabled()
     {
         self::mockConfig(['hyde.pretty_urls' => true]);
-        $this->assertEquals('/foo/bar.jpg', Hyde::formatLink('/foo/bar.jpg'));
+        $this->assertSame('/foo/bar.jpg', Hyde::formatLink('/foo/bar.jpg'));
     }
 
     public function testHelperRewritesIndexWhenUsingPrettyUrls()
     {
         self::mockConfig(['hyde.pretty_urls' => true]);
-        $this->assertEquals('/', Hyde::formatLink('index.html'));
+        $this->assertSame('/', Hyde::formatLink('index.html'));
     }
 
     public function testHelperDoesNotRewriteIndexWhenNotUsingPrettyUrls()
     {
         self::mockConfig(['hyde.pretty_urls' => false]);
-        $this->assertEquals('index.html', Hyde::formatLink('index.html'));
+        $this->assertSame('index.html', Hyde::formatLink('index.html'));
     }
 
     public function testHelperRewritesDocumentationPageIndexWhenUsingPrettyUrls()
     {
         self::mockConfig(['hyde.pretty_urls' => true]);
-        $this->assertEquals('docs/', Hyde::formatLink('docs/index.html'));
+        $this->assertSame('docs/', Hyde::formatLink('docs/index.html'));
     }
 
     public function testHelperDoesNotRewriteDocumentationPageIndexWhenNotUsingPrettyUrls()
     {
         self::mockConfig(['hyde.pretty_urls' => false]);
-        $this->assertEquals('docs/index.html', Hyde::formatLink('docs/index.html'));
+        $this->assertSame('docs/index.html', Hyde::formatLink('docs/index.html'));
     }
 
     public function testHelpersRewritesArbitraryNestedIndexPagesWhenUsingPrettyUrls()
     {
         self::mockConfig(['hyde.pretty_urls' => true]);
-        $this->assertEquals('foo/bar/', Hyde::formatLink('foo/bar/index.html'));
+        $this->assertSame('foo/bar/', Hyde::formatLink('foo/bar/index.html'));
     }
 
     public function testHelpersDoesNotRewriteArbitraryNestedIndexPagesWhenNotUsingPrettyUrls()
     {
         self::mockConfig(['hyde.pretty_urls' => false]);
-        $this->assertEquals('foo/bar/index.html', Hyde::formatLink('foo/bar/index.html'));
+        $this->assertSame('foo/bar/index.html', Hyde::formatLink('foo/bar/index.html'));
     }
 }
diff --git a/tests/Unit/Pages/HtmlPageTest.php b/tests/Unit/Pages/HtmlPageTest.php
@@ -18,7 +18,7 @@ public function testHtmlPageCanBeCompiled()
 
         $page = new HtmlPage('foo');
 
-        $this->assertEquals('bar', $page->compile());
+        $this->assertSame('bar', $page->compile());
     }
 
     public function testCompileMethodUsesContents()

diff --git a/tests/Unit/Pages/MarkdownPageTest.php b/tests/Unit/Pages/MarkdownPageTest.php
@@ -27,9 +27,10 @@ public function testCreatedModelContainsExpectedData()
         $this->file('_pages/test-page.md', "# Test Page \n Hello World!");
         $page = MarkdownPage::parse('test-page');
 
-        $this->assertEquals('Test Page', $page->title);
+        $this->assertSame('Test Page', $page->title);
+        $this->assertSame('test-page', $page->identifier);
+        $this->assertSame("# Test Page \n Hello World!", $page->markdown->body());
         $this->assertEquals("# Test Page \n Hello World!", $page->markdown);
-        $this->assertEquals('test-page', $page->identifier);
     }
 
     public function testCanRenderMarkdownPage()