Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made port default to value specific in config file or in .env #560

Merged
merged 2 commits into from
Oct 30, 2022

Conversation

rgasch
Copy link
Contributor

@rgasch rgasch commented Oct 29, 2022

This patch allows you to set a server port in the hyde.php config file while still defaulting to 8080.

For completeness, the (commented-out) entry

# SERVER_PORT=8080

should also be added to .env.example in the hyde app/distribution repository.

@caendesilva caendesilva self-requested a review October 30, 2022 10:18
@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Merging #560 (4684e56) into master (9e12e21) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #560   +/-   ##
=======================================
  Coverage   90.90%   90.90%           
=======================================
  Files           3        3           
  Lines          33       33           
=======================================
  Hits           30       30           
  Misses          3        3           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@caendesilva caendesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants