Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order subfolders in the Navigation #229

Closed
eriteric opened this issue Oct 7, 2023 · 8 comments · Fixed by hydephp/develop#1387
Closed

Order subfolders in the Navigation #229

eriteric opened this issue Oct 7, 2023 · 8 comments · Fixed by hydephp/develop#1387
Assignees
Labels
bug Something isn't working

Comments

@eriteric
Copy link

eriteric commented Oct 7, 2023

I have a couple of dropdown navigation items (automatically created from subfolders in _pages)
How do I target them in the the config/hyde.php's navigation => order?

I have tried the following:

            'mysubdirectory/index' => 20,
            'mysubdirectory/*' => 20,
            'mysubdirectory/' => 20,
            'mysubdirectory' => 20,
            '/mysubdirectory' => 20,
            '/mysubdirectory/' => 20,

Also tried assigning a priority number to each page in the subfolder, but to no effect:

            'mysubdirectory/mypage' => 20,
            'mysubdirectory/mypage2' => 20,
            'mysubdirectory/mypage3' => 20,

@eriteric eriteric changed the title Organize subfolders in the Navigation Order subfolders in the Navigation Oct 7, 2023
@caendesilva
Copy link
Member

Hi! So sorry for missing this issue! I'm going to look at this tomorrow!

@caendesilva caendesilva self-assigned this Oct 18, 2023
@caendesilva
Copy link
Member

Okay, so I confirmed that all dropdowns get the priority 999, so this is a confirmed bug. I'm going to work on a fix ASAP to allow dropdown navigation items to support config priorities.

@eriteric
Copy link
Author

Thanks! @caendesilva

@caendesilva
Copy link
Member

You're welcome! I'm working on preparing the release, I'll ping you when it's published! (Need to fix some tests first)

@caendesilva
Copy link
Member

@eriteric Update v1.2.1 is live! Run composer update hyde/framework and you should be good to go!

@eriteric
Copy link
Author

Thanks, I've updated Hyde.

Just a note: Check out Folio in Laravel 11!

@caendesilva
Copy link
Member

Thanks, I've updated Hyde.

Just a note: Check out Folio in Laravel 11!

Awesome, I hope it works well! And yeah, Folio is super cool!

@eriteric
Copy link
Author

Yes it's working now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants