Set private modofier for hid.hydra.Account#put* methods

hydra-billing · Feb 17, 2020 · ac0ce83 · ac0ce83
1 parent 4b84ec4
commit ac0ce83
Showing 1 changed file with 26 additions and 12 deletions.
diff --git a/src/org/camunda/latera/bss/connectors/hid/hydra/Account.groovy b/src/org/camunda/latera/bss/connectors/hid/hydra/Account.groovy
@@ -302,7 +302,7 @@ trait Account {
     return putCustomerAccount(input + [accountId: accountId])
   }
 
-  Boolean putAdjustment(Map input) {
+  private Boolean putAdjustment(Map input) {
     LinkedHashMap params = mergeParams([
       accountId     : null,
       docId         : null,
@@ -340,7 +340,7 @@ trait Account {
     return putAdjustment(input + [accountId: accountId])
   }
 
-  Boolean putPermanentOverdraft(Map input) {
+  private Boolean putPermanentOverdraft(Map input) {
     LinkedHashMap params = mergeParams([
       accountId : null,
       reasonId  : getDefaultOverdraftReasonId(),
@@ -367,20 +367,20 @@ trait Account {
     return putPermanentOverdraft(params.accountId, params.sum, params.reasonId)
   }
 
-  Boolean putPermanentOverdraft(
+  Boolean addPermanentOverdraft(Map input, def accountId) {
+    return putPermanentOverdraft(input + [accountId: accountId])
+  }
+
+  Boolean addPermanentOverdraft(
     def accountId,
-    Double sum = 0,
+    Double sum  = 0,
     def reasonId = getDefaultOverdraftReasonId()
   ) {
-    return putPermanentOverdraft(
+    return putPermanentOverdraft([
       accountId : accountId,
       sum       : sum,
       reasonId  : reasonId
-    )
-  }
-
-  Boolean addPermanentOverdraft(Map input = [:], def accountId) {
-    return putPermanentOverdraft(input + [accountId: accountId])
+    ])
   }
 
   Boolean deletePermanentOverdraft(def accountId) {
@@ -398,7 +398,7 @@ trait Account {
     }
   }
 
-  Boolean putTemporalOverdraft(Map input) {
+  private Boolean putTemporalOverdraft(Map input) {
     LinkedHashMap params = mergeParams([
       accountId : null,
       sum       : 0,
@@ -426,10 +426,24 @@ trait Account {
     }
   }
 
-  Boolean addTemporalOverdraft(Map input = [:], def accountId) {
+  Boolean addTemporalOverdraft(Map input, def accountId) {
     return putTemporalOverdraft(input + [accountId: accountId])
   }
 
+  Boolean addTemporalOverdraft(
+    def accountId,
+    Double sum = 0,
+    Temporal endDate = dayEnd(),
+    def reasonId = getDefaultOverdraftReasonId()
+  ) {
+    return putTemporalOverdraft([
+      accountId : accountId,
+      sum       : sum,
+      endDate   : endDate,
+      reasonId  : reasonId
+    ])
+  }
+
   Boolean deleteTemporalOverdraft(def accountId) {
     try {
       logger.info("Deleting temporal overdraft with params ${params}")