HCX-25 Fix MailSender class methods return values

CHANGELOG.md

@@ -37,6 +37,7 @@ v1.4.1 [unreleased]
 -   [#12](https://github.com/latera/camunda-ext/pull/12) Fix helpers.Hydra#parseRegion method
 -   [#207b8cc](https://github.com/latera/camunda-ext/commit/207b8cc) Fix exception while getting constant with spaces in code
 -   [#7a30801](https://github.com/latera/camunda-ext/commit/7a30801) Fix names of methods getConstantByCode and getConstantCode
+-   [#19](https://github.com/latera/camunda-ext/pull/19) Fix MailSender class methods return values
 
 v1.4 [2020-01-13]
 -------------------

src/org/camunda/latera/bss/connectors/Mail.groovy → src/org/camunda/latera/bss/connectors/MailSender.groovy

@@ -93,7 +93,7 @@ class MailSender {
     return this
   }
 
-  MailSender getHost() {
+  String getHost() {
     return this.host
   }
 
@@ -103,7 +103,7 @@ class MailSender {
     return this
   }
 
-  MailSender getPort() {
+  Integer getPort() {
     return this.port
   }
 
@@ -117,7 +117,7 @@ class MailSender {
     return setPort(port.toInteger())
   }
 
-  MailSender getUser() {
+  String getUser() {
     return this.user
   }
 
@@ -162,10 +162,10 @@ class MailSender {
     return this
   }
 
-  MailSender addFile(CharSequence filename, Object datasource){
+  MailSender addFile(CharSequence name, Object datasource) {
     MimeBodyPart part = new MimeBodyPart()
     part.setDataHandler(new DataHandler(datasource, 'application/octet-stream'))
-    part.setFileName(filename.toString())
+    part.setFileName(MimeUtility.encodeText(name, 'UTF-8', null))
     this.multipart.addBodyPart(part)
     return this
   }
@@ -179,14 +179,19 @@ class MailSender {
     return this
   }
 
-  void send(){
+  Boolean send() {
+    Boolean result = true
     connect()
     try {
       this.message.setContent(this.multipart)
       this.transport.sendMessage(this.message, this.message.getAllRecipients())
-    }
-    finally {
+    } catch (Exception e) {
+      logger.error(e)
+      result = false
+    } finally {
       transport.close()
     }
+
+    return result
   }
 }