HCX-12 Add methods for files to document attaching #24
Conversation
|
don't forget to update changelog |
NatalieKor
force-pushed
the
HCX-12
branch
2 times, most recently
from
92eded8 to
6468164
Compare
|
Please don't forget to backport to v1.4 |
| @@ -16,6 +16,10 @@ trait File { | |||
| return getFileEntityType(getSubjectEntityType(subjectId), id) | |||
| } | |||
|
|
|||
| Map getContractFileEntityType(def contractId, def id = null) { | |||
| return getFileEntityType(getContractEntityType(contractId), id) | |||
There was a problem hiding this comment.
No, this is not really how it works.
Firstly, getContractEntityType requires not only contract id itself, but also parent entity url part because for contract creation/update/delete urls should looks like subjects/customers/:customer_id/contracts/:contract_id. You cannot just skip parent part here because url will be malformed. Also calling this method without passing a parent will cause exception.
Secondly, there is no entpoint like subjects/customers/:customer_id/contracts/:contract_id/files you're trying to use for attaching files to contract. Real url should look like documents/:document:id/files.
Thirdly, you can attach files to any document as well as any subject. Currently there are methods to work with any subject files like getSubjectFiles. So here should be getDocumentFiles instead of getContractFiles.
No description provided.