fix(hydroflow_plus): rewrite IR in place to avoid stack overflow and …

…disable cloning (#1404)

Cloning was unsafe because values behind a `Rc<RefCell<...>>` in the
case of tee would be entangled with the old IR.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with
[ReviewStack](https://reviewstack.dev/hydro-project/hydroflow/pull/1404).
* #1405
* #1398
* __->__ #1404

hydroflow_plus/src/builder/built.rs

@@ -46,7 +46,7 @@ impl<'a> BuiltFlow<'a> {
     }
 }
 
-pub(crate) fn build_inner(ir: Vec<HfPlusLeaf>) -> BTreeMap<usize, HydroflowGraph> {
+pub(crate) fn build_inner(ir: &mut Vec<HfPlusLeaf>) -> BTreeMap<usize, HydroflowGraph> {
     let mut builders = BTreeMap::new();
     let mut built_tees = HashMap::new();
     let mut next_stmt_id = 0;
@@ -69,7 +69,7 @@ impl<'a> BuiltFlow<'a> {
         self.used = true;
 
         HfCompiled {
-            hydroflow_ir: build_inner(std::mem::take(&mut self.ir)),
+            hydroflow_ir: build_inner(&mut self.ir),
             extra_stmts: BTreeMap::new(),
             _phantom: PhantomData,
         }

hydroflow_plus/src/builder/deploy.rs

@@ -44,7 +44,7 @@ impl<'a, D: Deploy<'a>> DeployFlow<'a, D> {
         self.used = true;
 
         let mut seen_tees: HashMap<_, _> = HashMap::new();
-        let ir_leaves_networked: Vec<HfPlusLeaf> = std::mem::take(&mut self.ir)
+        let mut ir_leaves_networked: Vec<HfPlusLeaf> = std::mem::take(&mut self.ir)
             .into_iter()
             .map(|leaf| leaf.compile_network::<D>(env, &mut seen_tees, &self.nodes, &self.clusters))
             .collect();
@@ -81,7 +81,7 @@ impl<'a, D: Deploy<'a>> DeployFlow<'a, D> {
         }
 
         HfCompiled {
-            hydroflow_ir: build_inner(ir_leaves_networked),
+            hydroflow_ir: build_inner(&mut ir_leaves_networked),
             extra_stmts,
             _phantom: PhantomData,
         }
@@ -94,7 +94,7 @@ impl<'a, D: Deploy<'a, CompileEnv = ()>> DeployFlow<'a, D> {
         self.used = true;
 
         let mut seen_tees_instantiate: HashMap<_, _> = HashMap::new();
-        let ir_leaves_networked: Vec<HfPlusLeaf> = std::mem::take(&mut self.ir)
+        let mut ir_leaves_networked: Vec<HfPlusLeaf> = std::mem::take(&mut self.ir)
             .into_iter()
             .map(|leaf| {
                 leaf.compile_network::<D>(
@@ -106,7 +106,7 @@ impl<'a, D: Deploy<'a, CompileEnv = ()>> DeployFlow<'a, D> {
             })
             .collect();
 
-        let mut compiled = build_inner(ir_leaves_networked.clone());
+        let mut compiled = build_inner(&mut ir_leaves_networked);
         let mut meta = D::Meta::default();
 
         let (mut processes, mut clusters) = (