feat(hydroflow_plus): use trybuild to compile subgraph binaries #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying hydroflow with
|
| Latest commit: |
d4134d2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0f7429b1.hydroflow.pages.dev |
| Branch Preview URL: | https://pr1398.hydroflow.pages.dev |
shadaj
force-pushed
the
pr1398
branch
19 times, most recently
from
d4147cf
to
d09e40b
Compare
shadaj
force-pushed
the
pr1398
branch
7 times, most recently
from
f06bb2d
to
53b0c7d
Compare
|
For now, to compile in release mode you must manually provide the appropriate rustc flags. I'm going to leave supporting Cargo profiles to a later PR, that requires much more work. |
|
shadaj
force-pushed
the
pr1398
branch
4 times, most recently
from
87e9a4a
to
beb7568
Compare
Comment on lines
+282
to
+285
| None, // Python API doesn't support rustflags | ||
| None, // Python API doesn't support target_dir | ||
| false, // Python API doesn't support no_default_features | ||
| None, // Python API doesn't support perf |
There was a problem hiding this comment.
are we keeping the python API around?
There was a problem hiding this comment.
I guess for now... not super sure if we care to maintain it going forward though. Probably a separate discussion to have.
MingweiSamuel
approved these changes
Aug 21, 2024
shadaj
added a commit
that referenced
this pull request
Aug 21, 2024
…disable cloning (#1404) Cloning was unsafe because values behind a `Rc<RefCell<...>>` in the case of tee would be entangled with the old IR. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/hydro-project/hydroflow/pull/1404). * #1405 * #1398 * __->__ #1404
shadaj
force-pushed
the
pr1398
branch
5 times, most recently
from
e3bb4a7
to
a3456c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1307