-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(variadics): add traits for dealing with variadics of references #1324
feat(variadics): add traits for dealing with variadics of references #1324
Conversation
1c076be
to
58297fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems OK but clearer documentation on usage (with examples) would be helpful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small suggestions on naming/API
variadics/src/lib.rs
Outdated
/// | ||
/// ```rust | ||
/// # use variadics::*; | ||
/// let un_ref: <var_type!(&u32, &String, &bool) as RefVariadic>::UnRef = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no way to make this a method call so it rhymes with the other things here?
variadics/src/lib.rs
Outdated
/// | ||
/// ```rust | ||
/// # use variadics::*; | ||
/// let un_mut: <var_type!(&mut u32, &mut String, &mut bool) as MutVariadic>::UnMut = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar comment to unref
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…1324) Renames some traits, but not a breaking change since there hasn't been a release that includes those traits.
Renames some traits, but not a breaking change since there hasn't been a release that includes those traits.