Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(variadics): add traits for dealing with variadics of references #1324

Merged
merged 9 commits into from
Jul 2, 2024

Conversation

MingweiSamuel
Copy link
Member

Renames some traits, but not a breaking change since there hasn't been a release that includes those traits.

Copy link
Contributor

@jhellerstein jhellerstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems OK but clearer documentation on usage (with examples) would be helpful

variadics/src/lib.rs Show resolved Hide resolved
variadics/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@jhellerstein jhellerstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions on naming/API

///
/// ```rust
/// # use variadics::*;
/// let un_ref: <var_type!(&u32, &String, &bool) as RefVariadic>::UnRef =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no way to make this a method call so it rhymes with the other things here?

///
/// ```rust
/// # use variadics::*;
/// let un_mut: <var_type!(&mut u32, &mut String, &mut bool) as MutVariadic>::UnMut =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comment to unref

variadics/src/lib.rs Outdated Show resolved Hide resolved
@MingweiSamuel MingweiSamuel removed the request for review from rohitkulshreshtha July 2, 2024 15:52
Copy link
Contributor

@jhellerstein jhellerstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MingweiSamuel MingweiSamuel enabled auto-merge (squash) July 2, 2024 19:52
@MingweiSamuel MingweiSamuel merged commit 20080cb into hydro-project:main Jul 2, 2024
13 checks passed
jhellerstein pushed a commit that referenced this pull request Jul 29, 2024
…1324)

Renames some traits, but not a breaking change since there hasn't been a
release that includes those traits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants