refactor(hydro_deploy)!: use buildstructor to handle excessive Deployment method arguments, fix #1364
#1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadaj
reviewed
Jul 29, 2024
| #[buildstructor::buildstructor] | ||
| impl Deployment { | ||
| #[allow(clippy::too_many_arguments)] | ||
| #[builder(entry = "GcpComputeEngineHost", exit = "add")] |
There was a problem hiding this comment.
I wonder if it is possible to have exit be just drop (or is that asking for too much haha)?
There was a problem hiding this comment.
Hmm it is theoretically possible but the macro isn't implemented to support it -- also I think that would be too fancy. Though the macro ought to mark the struct #[must_use] BrynCooke/buildstructor#189
There was a problem hiding this comment.
Perhaps should be called GcpComputeEngineHostBuilder and .build()
…loyment` method arguments, fix hydro-project#1364 Adds new method `Deployment::AzureHost` BREAKING CHANGE: Changes syntax for `Deployment::GcpComputeEngineHost`
MingweiSamuel
force-pushed
the
buildstructor
branch
from
0b6db7c
to
decbbb1
Compare
…ve `Deployment` method arguments, fix hydro-project#1364
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new method
Deployment::AzureHostBREAKING CHANGE: Changes syntax for
Deployment::GcpComputeEngineHost