Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hydroflow): add cross_singleton operator #1373

Merged
merged 1 commit into from
Aug 6, 2024
Merged

feat(hydroflow): add cross_singleton operator #1373

merged 1 commit into from
Aug 6, 2024

Conversation

shadaj
Copy link
Member

@shadaj shadaj commented Aug 3, 2024

This operator is necessary to eliminate performance bottlenecks in Paxos where cross-products result in unnecessary cloning and lack of short-circuit behavior results in values being cloned out of the internal state of reduce_keyed.

Copy link

cloudflare-workers-and-pages bot commented Aug 3, 2024

Deploying hydroflow with  Cloudflare Pages  Cloudflare Pages

Latest commit: 62b4e9d
Status: ✅  Deploy successful!
Preview URL: https://5969d4b0.hydroflow.pages.dev
Branch Preview URL: https://pr1373.hydroflow.pages.dev

View logs

Copy link
Member

@MingweiSamuel MingweiSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

hydroflow_lang/src/graph/ops/cross_singleton.rs Outdated Show resolved Hide resolved
This operator is necessary to eliminate performance bottlenecks in Paxos where cross-products result in unnecessary cloning and lack of short-circuit behavior results in values being cloned out of the internal state of `reduce_keyed`.
@shadaj shadaj merged commit bd793e2 into main Aug 6, 2024
27 checks passed
@shadaj shadaj deleted the pr1373 branch August 6, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants