Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #1418

Closed
wants to merge 8 commits into from
Closed

chore: update dependencies #1418

wants to merge 8 commits into from

Conversation

shadaj
Copy link
Member

@shadaj shadaj commented Aug 22, 2024

Copy link

cloudflare-workers-and-pages bot commented Aug 22, 2024

Deploying hydroflow with  Cloudflare Pages  Cloudflare Pages

Latest commit: f6df246
Status:⚡️  Build in progress...

View logs

@MingweiSamuel
Copy link
Member

MingweiSamuel commented Aug 22, 2024

Probably best to keep the non-breaking versions the same, or at least keep the minor versions, as a lower bound for what is needed

1.2.3  :=  >=1.2.3, <2.0.0
1.2    :=  >=1.2.0, <2.0.0
1      :=  >=1.0.0, <2.0.0

@shadaj
Copy link
Member Author

shadaj commented Aug 23, 2024

The algorithm I used for how much to drop was to use just major version when:
a) we aren't depending on some very low level internal detail of the library
b) the library has established practices for prevent breaking changes

For others it's major.minor.

@MingweiSamuel
Copy link
Member

"the package hydroflow depends on tokio-stream, with features: io-util but tokio-stream does not have these features"

cargo +nightly -Zdirect-minimal-versions update

I'll go thru and find the minimal versions and add them to this PR

@MingweiSamuel
Copy link
Member

#1423

MingweiSamuel added a commit that referenced this pull request Aug 24, 2024
…ck` (#1423)

Moved from #1418

---------

Co-authored-by: Shadaj Laddad <shadaj@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants