MidiCommon: merge SYSTEM_EXCLUSIVE into SYSEX #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After reading into both MIDI specs and doc as well as PortMidi api doc I came to the conclusion that the separate handling (and mere existance) of `SYSTEM_EXCLUSIVE` and `SYSEX` MIDI type must have been an accident. This fix should enable MMC MIDI control using PortMidi (I have no hardware to test this). Fixes hydrogen-music#1773
|
Note: this does not enable MMC message handling in PortMidi yet. Collecting the data corresponding to a SysEx message is not implemented yet. (Probably that's why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reading into both MIDI specs and doc as well as PortMidi API doc I came to the conclusion that the separate handling (and mere existence) of
SYSTEM_EXCLUSIVEandSYSEXMIDI type must have been an accident.This fix should enable MMC MIDI control using PortMidi (I have no hardware to test this).
Fixes #1773