Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrapping _config/index.json #9

Closed
hyesungoh opened this issue Mar 29, 2022 · 0 comments · Fixed by #10
Closed

wrapping _config/index.json #9

hyesungoh opened this issue Mar 29, 2022 · 0 comments · Fixed by #10
Assignees
@hyesungoh
Labels
refactor This seems like refactorable

Comments

@hyesungoh
Copy link
Owner

as is

import config from "../_config/index.json";
const { blogUrl } = config;

to be

import { blogUrl } from "../_config";
@hyesungoh hyesungoh added the refactor This seems like refactorable label Mar 29, 2022
@hyesungoh hyesungoh self-assigned this Mar 29, 2022
@hyesungoh hyesungoh linked a pull request Mar 29, 2022 that will close this issue
refactor: #9 #10
Merged
hyesungoh added a commit that referenced this issue Mar 29, 2022
@hyesungoh
Merge pull request #10 from hyesungoh/refactor/#9
656d993 
refactor: #9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hyesungoh hyesungoh

Labels
refactor This seems like refactorable
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: #9 hyesungoh/comet-land
1 participant
@hyesungoh