Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing design issue at Author section's kbar button #108

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Conversation

hyesungoh
Copy link
Owner

Description

  • replace flex-grow to flex-shrink option at KbarButtonWrapper
  • append width attr at KBarToggleButton

closes #107

@hyesungoh hyesungoh added bug Something isn't working style Change design or request it labels Jul 27, 2022
@hyesungoh hyesungoh self-assigned this Jul 27, 2022
@vercel
Copy link

vercel bot commented Jul 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
comet-land-blog ✅ Ready (Inspect) Visit Preview Jul 27, 2022 at 1:08PM (UTC)
comet-land-resume ✅ Ready (Inspect) Visit Preview Jul 27, 2022 at 1:08PM (UTC)

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #108 (34913b9) into main (5a8a77c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #108   +/-   ##
=======================================
  Coverage   91.25%   91.26%           
=======================================
  Files         104      104           
  Lines        2906     2907    +1     
  Branches      480      481    +1     
=======================================
+ Hits         2652     2653    +1     
  Misses        254      254           
Impacted Files Coverage Δ
...log/src/components/AuthorSection/AuthorSection.tsx 100.00% <100.00%> (ø)
packages/core/components/Kbar/KBarToggleButton.tsx 96.55% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a8a77c...34913b9. Read the comment docs.

@cypress
Copy link

cypress bot commented Jul 27, 2022



Test summary

24 0 0 0


Run details

Project blog
Status Passed
Commit 57e13d3 ℹ️
Started Jul 27, 2022 1:09 PM
Ended Jul 27, 2022 1:10 PM
Duration 01:05 💡
OS Linux Ubuntu - 20.04
Browser Chrome 103

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Jul 27, 2022



Test summary

16 0 0 0


Run details

Project resume
Status Passed
Commit 57e13d3 ℹ️
Started Jul 27, 2022 1:11 PM
Ended Jul 27, 2022 1:11 PM
Duration 00:19 💡
OS Linux Ubuntu - 20.04
Browser Chrome 103

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@hyesungoh hyesungoh merged commit 7dde557 into main Jul 27, 2022
@hyesungoh hyesungoh deleted the issue/107 branch July 27, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working style Change design or request it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Author section button position
1 participant