Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: scroll-restore at all page #149

Merged
merged 10 commits into from
Nov 12, 2023
Merged

feat: scroll-restore at all page #149

merged 10 commits into from
Nov 12, 2023

Conversation

hyesungoh
Copy link
Owner

Description

scroll restore at all page

now attached at category and main page only

@hyesungoh hyesungoh self-assigned this Nov 7, 2023
@vercel Vercel
Copy link

vercel bot commented Nov 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
comet-land-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2023 9:42am
comet-land-resume ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2023 9:42am

@github-actions github-actions bot added the area: blog About blog label Nov 7, 2023
@hyesungoh hyesungoh added the enhancement New feature or request label Nov 7, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 7, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3bad461) 91.65% compared to head (3f24a02) 91.50%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   91.65%   91.50%   -0.15%     
==========================================
  Files         104      104              
  Lines        2948     2944       -4     
  Branches      536      536              
==========================================
- Hits         2702     2694       -8     
- Misses        246      250       +4
Files Coverage Δ
apps/blog/src/pages/_app.page.tsx 72.09% <100.00%> (-1.08%) ⬇️
apps/blog/src/pages/category/[category].page.tsx 72.00% <ø> (-1.08%) ⬇️
apps/blog/src/pages/index.page.tsx 89.74% <ø> (-0.51%) ⬇️
apps/blog/src/hooks/useScrollRestoration.ts 39.62% <0.00%> (-7.66%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress Cypress
Copy link

cypress bot commented Nov 7, 2023 •
edited
Loading

Passing run #175 ↗︎

0 26 0 0 Flakiness 0

Details:

Merge 3f24a02 into 3bad461...
Project: blog Commit: 25c9fcd3b0 ℹ️
Status: Passed Duration: 01:01 💡
Started: Nov 12, 2023 9:40 AM Ended: Nov 12, 2023 9:41 AM

Review all test suite changes for PR #149 ↗︎

@github-actions github-actions bot added the test: e2e Apply new e2e test or request test code label Nov 7, 2023
@github-actions github-actions bot added the area: resume About resume label Nov 9, 2023
@hyesungoh
Copy link
Owner Author

cypress loading issue in cypress-io/cypress#14857

@cypress Cypress
Copy link

cypress bot commented Nov 12, 2023

Passing run #156 ↗︎

0 16 0 0 Flakiness 0

Details:

Merge 3f24a02 into 3bad461...
Project: resume Commit: 25c9fcd3b0 ℹ️
Status: Passed Duration: 00:20 💡
Started: Nov 12, 2023 9:42 AM Ended: Nov 12, 2023 9:42 AM

Review all test suite changes for PR #149 ↗︎

@hyesungoh hyesungoh merged commit 98bd0e2 into main Nov 12, 2023
11 checks passed
@hyesungoh hyesungoh deleted the chore/scroll-restore-at-all-page branch November 12, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hyesungoh hyesungoh

Labels
area: blog About blog area: resume About resume enhancement New feature or request test: e2e Apply new e2e test or request test code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hyesungoh