Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace some files at resume / apply new docs for contributing #60

Merged
merged 4 commits into from
Jun 11, 2022

Conversation

hyesungoh
Copy link
Owner

@hyesungoh hyesungoh commented Jun 11, 2022

  • resume/src/costants/kbarActions to resume/src/libs/kbarActions
  • apply below documentation
    • code of conduct
    • pull request template
    • contributing guide

closed #54

@hyesungoh hyesungoh self-assigned this Jun 11, 2022
@vercel
Copy link

vercel bot commented Jun 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
comet-land-blog ✅ Ready (Inspect) Visit Preview Jun 11, 2022 at 0:59AM (UTC)
comet-land-resume ✅ Ready (Inspect) Visit Preview Jun 11, 2022 at 0:59AM (UTC)

@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #60 (10feee9) into main (26fcc17) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main      #60   +/-   ##
=======================================
  Coverage   61.10%   61.10%           
=======================================
  Files         104      104           
  Lines        2975     2975           
  Branches      495      495           
=======================================
  Hits         1818     1818           
  Misses       1157     1157           
Impacted Files Coverage Δ
...e/src/components/WorkExperienceSection/Project.tsx 100.00% <ø> (ø)
apps/resume/src/libs/KbarActions/KbarActions.ts 93.93% <ø> (ø)
apps/resume/src/libs/KbarActions/index.ts 100.00% <ø> (ø)
apps/resume/src/pages/_app.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea32027...10feee9. Read the comment docs.

@cypress
Copy link

cypress bot commented Jun 11, 2022



Test summary

1 0 0 0


Run details

Project blog
Status Passed
Commit f348154 ℹ️
Started Jun 11, 2022 1:00 PM
Ended Jun 11, 2022 1:00 PM
Duration 00:10 💡
OS Linux Ubuntu - 20.04
Browser Chrome 102

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Jun 11, 2022



Test summary

1 0 0 0


Run details

Project resume
Status Passed
Commit f348154 ℹ️
Started Jun 11, 2022 1:01 PM
Ended Jun 11, 2022 1:01 PM
Duration 00:09 💡
OS Linux Ubuntu - 20.04
Browser Chrome 102

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@hyesungoh hyesungoh changed the title Replace resume app's kbarActions to libs directory Replace some files at resume / apply new docs for contributing Jun 11, 2022
@hyesungoh hyesungoh added documentation Improvements or additions to documentation refactor This seems like refactorable labels Jun 11, 2022
@hyesungoh hyesungoh merged commit c582e62 into main Jun 11, 2022
@hyesungoh hyesungoh deleted the issue/54 branch June 11, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation refactor This seems like refactorable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace resume app's constant/kbarAction to libs
1 participant