Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle valid resumeUrl at blog app #64

Merged
merged 2 commits into from
Jun 20, 2022
Merged

handle valid resumeUrl at blog app #64

merged 2 commits into from
Jun 20, 2022

Conversation

hyesungoh
Copy link
Owner

Description

not render resume at kbar menu when invalid resumeUrl

closed #52

@hyesungoh hyesungoh added the fix Fixing bug label Jun 20, 2022
@hyesungoh hyesungoh self-assigned this Jun 20, 2022
@vercel
Copy link

vercel bot commented Jun 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
comet-land-blog ✅ Ready (Inspect) Visit Preview Jun 20, 2022 at 3:39PM (UTC)
comet-land-resume ✅ Ready (Inspect) Visit Preview Jun 20, 2022 at 3:39PM (UTC)

@cypress
Copy link

cypress bot commented Jun 20, 2022



Test summary

1 0 0 0


Run details

Project blog
Status Passed
Commit eb4c967 ℹ️
Started Jun 20, 2022 3:41 PM
Ended Jun 20, 2022 3:41 PM
Duration 00:11 💡
OS Linux Ubuntu - 20.04
Browser Chrome 102

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #64 (c28c1d5) into main (26fcc17) will increase coverage by 0.05%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   61.10%   61.16%   +0.05%     
==========================================
  Files         104      104              
  Lines        2975     2979       +4     
  Branches      495      498       +3     
==========================================
+ Hits         1818     1822       +4     
  Misses       1157     1157              
Impacted Files Coverage Δ
...e/src/components/WorkExperienceSection/Project.tsx 100.00% <ø> (ø)
apps/resume/src/libs/KbarActions/KbarActions.ts 93.93% <ø> (ø)
apps/resume/src/libs/KbarActions/index.ts 100.00% <ø> (ø)
apps/resume/src/pages/_app.tsx 0.00% <0.00%> (ø)
apps/blog/src/libs/kbarActions/index.ts 87.50% <100.00%> (+0.54%) ⬆️
...ckages/core/components/ThemeSwitch/ThemeSwitch.tsx 97.50% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d7b90a...c28c1d5. Read the comment docs.

@cypress
Copy link

cypress bot commented Jun 20, 2022



Test summary

1 0 0 0


Run details

Project resume
Status Passed
Commit eb4c967 ℹ️
Started Jun 20, 2022 3:42 PM
Ended Jun 20, 2022 3:42 PM
Duration 00:10 💡
OS Linux Ubuntu - 20.04
Browser Chrome 102

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@hyesungoh hyesungoh merged commit e527dae into main Jun 20, 2022
@hyesungoh hyesungoh deleted the issue/52 branch June 20, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

without resume url at blog
1 participant