Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Resume contact button bugs #82

Merged
merged 3 commits into from
Jul 4, 2022
Merged

fix Resume contact button bugs #82

merged 3 commits into from
Jul 4, 2022

Conversation

hyesungoh
Copy link
Owner

Description

  • does not clickable when above the text
  • too bottom to click (position)
  • does not follow primary color at shadow color

closes #81

@hyesungoh hyesungoh added fix Fixing bug style Change design or request it labels Jul 4, 2022
@hyesungoh hyesungoh self-assigned this Jul 4, 2022
@vercel
Copy link

vercel bot commented Jul 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
comet-land-blog ✅ Ready (Inspect) Visit Preview Jul 4, 2022 at 4:16AM (UTC)
comet-land-resume ✅ Ready (Inspect) Visit Preview Jul 4, 2022 at 4:16AM (UTC)

@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #82 (f6962b3) into main (5ebdf9b) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   75.09%   75.09%           
=======================================
  Files         104      104           
  Lines        2903     2903           
  Branches      479      479           
=======================================
  Hits         2180     2180           
  Misses        723      723           
Impacted Files Coverage Δ
apps/resume/src/pages/_app.tsx 0.00% <0.00%> (ø)
...ume/src/components/ContactButton/ContactButton.tsx 97.05% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ebdf9b...f6962b3. Read the comment docs.

@cypress
Copy link

cypress bot commented Jul 4, 2022



Test summary

1 0 0 0


Run details

Project blog
Status Passed
Commit 80f2fa4 ℹ️
Started Jul 4, 2022 4:17 AM
Ended Jul 4, 2022 4:18 AM
Duration 00:17 💡
OS Linux Ubuntu - 20.04
Browser Chrome 103

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Jul 4, 2022



Test summary

1 0 0 0


Run details

Project resume
Status Passed
Commit 80f2fa4 ℹ️
Started Jul 4, 2022 4:18 AM
Ended Jul 4, 2022 4:19 AM
Duration 00:13 💡
OS Linux Ubuntu - 20.04
Browser Chrome 103

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@hyesungoh hyesungoh merged commit fcbc37e into main Jul 4, 2022
@hyesungoh hyesungoh deleted the issue/81 branch July 4, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixing bug style Change design or request it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update Resume app's contact button
1 participant