Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compatibility with old node versions #16

Merged
merged 2 commits into from
Jul 3, 2020
Merged

fix: compatibility with old node versions #16

merged 2 commits into from
Jul 3, 2020

Conversation

hyj1991
Copy link
Owner

@hyj1991 hyj1991 commented Jul 3, 2020

No description provided.

@hyj1991 hyj1991 requested a review from Widdershin July 3, 2020 09:54
Widdershin
Widdershin reviewed Jul 3, 2020
View reviewed changes
src/profiler_data.cc
@@ -5,8 +5,7 @@ namespace nodex {
using v8::Context;
using v8::Isolate;

ProfilerData::ProfilerData(v8::Local<Context> newContext, Isolate* isolate) {
context = newContext;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up, at one point I was relying on data->context when I was using the v8 APIs instead of Nan.

Widdershin
Widdershin approved these changes Jul 3, 2020
View reviewed changes
Copy link
Collaborator

@Widdershin Widdershin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and builds and tests fine on a few older versions on my machine.

Thanks for sorting out the version issues. I'll add a test for the multi-threading support when I get back to work next week.

@hyj1991
Copy link
Owner Author

hyj1991 commented Jul 3, 2020

Looks good to me, and builds and tests fine on a few older versions on my machine.

Thanks for sorting out the version issues. I'll add a test for the multi-threading support when I get back to work next week.

OK

@hyj1991 hyj1991 merged commit 885da7c into master Jul 3, 2020
@hyj1991 hyj1991 mentioned this pull request Jul 9, 2020
Closed
@hyj1991 hyj1991 deleted the worker_threads branch May 27, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widdershin Widdershin Widdershin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyj1991 @Widdershin