Add test for worker thread support #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widdershin
force-pushed
the
worker-threads-test
branch
from
95c9a4e to
15ec637
Compare
hyj1991
reviewed
Jul 7, 2020
test/v8-profiler.js
Outdated
| profiler = require('../'); | ||
|
|
||
| const NODE_V_010 = /^v0\.10\.\d+$/.test(process.version); | ||
| const SOURCE_PATH = path.join(__dirname, '..'); | ||
|
|
||
| var workerThreads; |
There was a problem hiding this comment.
Here could be let, but I think we could open another pr to fix it because of many other var in the raw file.
There was a problem hiding this comment.
Breaks Node 4 and 5 on Travis
There was a problem hiding this comment.
Actually might just need a "use strict" in this file.
There was a problem hiding this comment.
Actually might just need a "use strict" in this file.
enen
Widdershin
force-pushed
the
worker-threads-test
branch
from
15ec637 to
9025e2b
Compare
Just a simple test, loading the module, capturing a small profile and sending it back over the wire. The test will be skipped if the worker_threads module can't be required.
Widdershin
force-pushed
the
worker-threads-test
branch
from
9025e2b to
cbecd20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a simple test, loading the module, capturing a small profile and
sending it back over the wire.
The test will be skipped if the worker_threads module can't be required.