Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better colour/formatting codes #101

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Better colour/formatting codes #101

merged 2 commits into from
Mar 15, 2023

Conversation

cs127
Copy link
Contributor

@cs127 cs127 commented Mar 13, 2023

Neofetch changes:

  • The color function distinguishes between 7 and fg properly (7 = white, fg = default foreground colour).
  • The strip_sequences function captures ANSI SGR escape codes more accurately.
  • The reset variable only resets the text colour and whether the text is bold or not, and doesn't reset anything else.
  • Added a workaround for showing bright colour blocks (8-15) in the Linux framebuffer console, by using the blinking text attribute (\e[5m).

Hyfetch changes:

  • Changed the Minecraft colour codes so that the dark ones don't reset anything, and the bright ones don't make the text bold.
  • Added the remaining Minecraft formatting codes.
  • Added extended formatting codes that reset specific things (e.g. colour, bold, italic) instead of everything.
  • Changed a bunch of "reset everything" (&r) codes in strings, to only reset the attributes they need to.

I tested everything as much as I could, but I might have missed some stuff. Feel free to let me know if there are any problems!

@hykilpikonna
Copy link
Owner

Looks good, thanks! <3

@hykilpikonna hykilpikonna merged commit 365ed5a into hykilpikonna:master Mar 15, 2023
@Glandos Glandos mentioned this pull request Jul 28, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants