Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the installation instructions for Arch Linux in the README #109

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Conversation

Antiz96
Copy link
Contributor

@Antiz96 Antiz96 commented Mar 23, 2023

Hi,

First of all, thanks a lot for your awesome work with hyfetch.

I recently moved it out from the AUR to Arch's official [community] repository. That means that hyfetch can now be installed with pacman such as any other "official/regular" packages. I hope it's okay for you!
This PR aims to update the installation instruction for Arch Linux accordingly in the README.

Since I'm now the new maintainer of the hyfetch package on Arch's [community] repo, I allowed myself to add my GitHub nickname to the "thank to [...]" section, after Aleksana's one (which is obviously listed as a contributor in the PKGBUILD by the way). If you want me to remove it or do it differently, don't hesitate to ask for a change! :)

On a side note, I had the following warning when building the package:

/usr/lib/python3.10/site-packages/setuptools/command/build_py.py:202: SetuptoolsDeprecationWarning:     Installing 'hyfetch.scripts' as data is deprecated, please list it in `packages`.
    !!


    ############################
    # Package would be ignored #
    ############################
    Python recognizes 'hyfetch.scripts' as an importable package,
    but it is not listed in the `packages` configuration of setuptools.

    'hyfetch.scripts' has been automatically added to the distribution only
    because it may contain data files, but this behavior is likely to change
    in future versions of setuptools (and therefore is considered deprecated).

    Please make sure that 'hyfetch.scripts' is included as a package by using
    the `packages` configuration field or the proper discovery methods
    (for example by using `find_namespace_packages(...)`/`find_namespace:`
    instead of `find_packages(...)`/`find:`).

    You can read more about "package discovery" and "data files" on setuptools
    documentation page.


!!

The compilation went fine regardless and the package is totally functional but I guess it's worth noticing it in case that can be fixed.
If you want me to create a separate issue for that, don't hesitate to tell me 😃

I remain available if needed 😄

@hykilpikonna hykilpikonna merged commit e970c8f into hykilpikonna:master Mar 24, 2023
@hykilpikonna
Copy link
Owner

This is great! Thank you so much for maintaining the package! And also thanks to @Aleksanaa for her contributions as well.

Also I just fixed the setup.py warning in 6192b47 and scheduled for the next release. Thanks for pointing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants