Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix an issue with bash 5.2 #24

Merged
merged 1 commit into from
Oct 4, 2022
Merged

fix an issue with bash 5.2 #24

merged 1 commit into from
Oct 4, 2022

Conversation

Un1q32
Copy link
Contributor

@Un1q32 Un1q32 commented Sep 30, 2022

No description provided.

@hykilpikonna
Copy link
Owner

Sorry for the delay, I was waiting for ArchLinux to push the bash 5.2 update but it's still on 5.1.16 as of now, so I just compiled from source.

Thank you for your contribution! Please make sure to attach a description of the issue in the future so we can know what issue it's fixing and what to test for.

So this pull request fixes the issue that, on bash 5.2, neofetch outputs after the last line of the system informations would be cut off.

Before fix:

image

After fix:

image

@hykilpikonna hykilpikonna merged commit e72fe4d into hykilpikonna:master Oct 4, 2022
@hykilpikonna
Copy link
Owner

I found a bug 🐛

This change would introduce an issue for bash 3.2.57, where the [m at the end isn't processed:

image

Since macOS preinstalls bash 3.2.57, this would be impactful. I've added a check for bash 3 to fix this:

image

If you have better solutions, please let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants