Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cargo bin dir #49

Merged
merged 2 commits into from
Dec 7, 2022
Merged

fix: cargo bin dir #49

merged 2 commits into from
Dec 7, 2022

Conversation

DaRacci
Copy link

@DaRacci DaRacci commented Dec 5, 2022

Use the environment variable to find the dir instead of the hard coded default

fix: cargo bin dir
30c50dc 
Use the environment variable to find the dir instead of the hard coded default
@hykilpikonna
Copy link
Owner

For some reason I don't have the environment variable $CARGO_HOME set up by default, but I do have the directory ~/.cargo/bin. It might be better to have a default fallback if $CARGO_HOME is not set (e.g. use "${CARGO_HOME:-$HOME/cargo}").

image

hykilpikonna
hykilpikonna reviewed Dec 7, 2022
View reviewed changes
neofetch Outdated Show resolved Hide resolved
@hykilpikonna
fix: path ins't set by default
1ac9680 
Co-authored-by: Hykilpikonna <me@hydev.org>
@hykilpikonna hykilpikonna merged commit 1b0cf4a into hykilpikonna:master Dec 7, 2022
@hykilpikonna
Copy link
Owner

Okay, it should work, thank you for the pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hykilpikonna hykilpikonna hykilpikonna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaRacci @hykilpikonna