Don't retry on success when deactivated

Fixes #53

CHANGELOG.md

@@ -15,6 +15,10 @@ You can find our backwards-compatibility policy [here](https://github.com/hynek/
 
 ## [Unreleased](https://github.com/hynek/stamina/compare/23.3.0...HEAD)
 
+### Fixed
+
+- Blocks used to be retried when *stamina* was set inactive when they succeeded – and only then.
+
 
 ## [23.3.0](https://github.com/hynek/stamina/compare/23.2.0...23.3.0) - 2023-12-05
 

src/stamina/_core.py

@@ -207,11 +207,11 @@ def with_name(
 
     def __iter__(self) -> Iterator[Attempt]:
         if not CONFIG.is_active:
-            for r in _t.Retrying(
-                reraise=True, stop=_STOP_NO_RETRY
-            ):  # pragma: no cover -- it's always once + GeneratorExit
+            for r in _t.Retrying(reraise=True, stop=_STOP_NO_RETRY):
                 yield Attempt(r)
 
+            return
+
         for r in _t.Retrying(
             before_sleep=_make_before_sleep(
                 self._name, CONFIG, self._args, self._kw

tests/test_async.py

@@ -127,6 +127,23 @@ async def f():
     assert 1 == num_called
 
 
+async def test_retry_inactive_block():
+    """
+    If inactive, don't retry.
+    """
+    num_called = 0
+
+    stamina.set_active(False)
+
+    with pytest.raises(Exception, match="passed"):  # noqa: PT012
+        async for attempt in stamina.retry_context(on=ValueError):
+            with attempt:
+                num_called += 1
+                raise Exception("passed")
+
+    assert 1 == num_called
+
+
 async def test_retry_inactive_ok():
     """
     If inactive, the happy path still works.
@@ -145,6 +162,21 @@ async def f():
     assert 1 == num_called
 
 
+async def test_retry_inactive_block_ok():
+    """
+    If inactive, the happy path still works.
+    """
+    num_called = 0
+
+    stamina.set_active(False)
+
+    async for attempt in stamina.retry_context(on=ValueError):
+        with attempt:
+            num_called += 1
+
+    assert 1 == num_called
+
+
 async def test_retry_block():
     """
     Async retry_context blocks are retried.

tests/test_sync.py

@@ -97,6 +97,23 @@ def f():
     assert 1 == num_called
 
 
+def test_retry_inactive_block():
+    """
+    If inactive, don't retry.
+    """
+    num_called = 0
+
+    stamina.set_active(False)
+
+    with pytest.raises(Exception, match="passed"):  # noqa: PT012
+        for attempt in stamina.retry_context(on=ValueError):
+            with attempt:
+                num_called += 1
+                raise Exception("passed")
+
+    assert 1 == num_called
+
+
 def test_retry_inactive_ok():
     """
     If inactive, the happy path still works.
@@ -115,6 +132,21 @@ def f():
     assert 1 == num_called
 
 
+def test_retry_inactive_block_ok():
+    """
+    If inactive, the happy path still works.
+    """
+    num_called = 0
+
+    stamina.set_active(False)
+
+    for attempt in stamina.retry_context(on=ValueError):
+        with attempt:
+            num_called += 1
+
+    assert 1 == num_called
+
+
 def test_retry_block():
     """
     Sync retry_context blocks are retried.