Use stdlib logging if structlog is missing #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. 🚀 |
|
Great thanks! And sorry for breaking your workaround. 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before I tackle configurability, here's stdlib logging by default if structlog is missing (should never happen but the world is what it is).
Does this look OK to you @estahn?
Ref #29
FTR: I've changed the key from slept to idle_for because it's a bit weird. Idle_for is the amount of time that will have been slept once the retry is started. Sadly, there doesn't seem to be a way to get just the current sleep value. I'll try to simulate it once this is merged.