Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add processor_chain arg to stdlib.ProcessorFormatter #335

Closed
wants to merge 8 commits into from

Conversation

Akuli
Copy link

@Akuli Akuli commented Jul 14, 2021

Fixes #334

  • Added tests for changed code.
  • Updated documentation for changed code.
    • New functions/classes have to be added to docs/api.rst by hand.
    • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives. Find the appropriate next version in our __init__.py file.
  • Documentation in .rst files is written using semantic newlines.
  • Changes (and possible deprecations) are documented in the changelog.

I'll add tests if any of this is actually a good idea. I'm new to structlog and there might already be a way to do what I wanted to do in #334 .

@hynek
Copy link
Owner

hynek commented Aug 28, 2021

I'm sorry, but we can't just remove such an important parameter.

Shouldn't it be possible to write a processor that wraps a chain? Processors should be composable, so maybe we should add more helpers to achieve that.

@Akuli
Copy link
Author

Akuli commented Aug 28, 2021

That makes sense. This just isn't a good approach.

@Akuli Akuli closed this Aug 28, 2021
@hynek
Copy link
Owner

hynek commented Nov 12, 2021

Hi @Akuli, ironically I'm working on something very similar. Would #365 work for you?

@Akuli
Copy link
Author

Akuli commented Nov 12, 2021

Thanks! Seems like it would work, although I no longer work on the project where I wanted this.

@Akuli Akuli deleted the processor-chain branch November 12, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiple processors to structlog.stdlib.ProcessorFormatter
2 participants