Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply capture_logs to initialized bound loggers #412

Merged
merged 1 commit into from
Apr 23, 2022
Merged

Apply capture_logs to initialized bound loggers #412

merged 1 commit into from
Apr 23, 2022

Conversation

fabianbuechler
Copy link
Contributor

@fabianbuechler fabianbuechler commented Apr 19, 2022 •
edited
Loading

Summary

This changes the structlog.testing.capture_logs contextmanager to also work for already initialized bound loggers.

Fixes #408.

Pull Request Check List

  • Added tests for changed code.
    • The CI fails with less than 100% coverage.
  • Changes (and possible deprecations) are documented in the changelog.
  • Consider granting push permissions to the PR branch, so maintainers can fix minor issues themselves without pestering you.

@fabianbuechler fabianbuechler marked this pull request as ready for review April 19, 2022 16:09
@fabianbuechler fabianbuechler mentioned this pull request Apr 19, 2022
Closed
hynek
hynek approved these changes Apr 23, 2022
View reviewed changes
Copy link
Owner

@hynek hynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@hynek hynek enabled auto-merge (squash) April 23, 2022 09:03
@hynek hynek merged commit 881d841 into hynek:main Apr 23, 2022
sscherfke pushed a commit to sscherfke/structlog that referenced this pull request May 21, 2022
@fabianbuechler @sscherfke
Apply capture_logs to initialized bound loggers (hynek#412)
4c73f85 
Fixes hynek#408
@hynek hynek mentioned this pull request Aug 6, 2022
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hynek hynek hynek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

capture_logs doesn't affect already initalized BoundLoggers
2 participants
@fabianbuechler @hynek