-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add log() to BoundLoggerFiltering* #413
Conversation
When you say BoundLogger, I presume you mean stdlib's one (yes, calling them all same was stupid)? There's really no guarantee to mirror stdlib APIs in general, do you find that method practically useful and if so how? Because it completely obliterates the performance gains we got by pre-creating concrete classes. |
Indeed. I like using
I use it to pipe stdlib logs into structlog.
It should only effect performance for calls that use |
OK thanks! I'll fix a few tiny quibbles myself, really weird to document this. 🤔 |
@hynek would you mind cutting a release that has this PR? Thanks! |
I plan on pushing 22.1 once #407 is merged. |
Co-authored-by: Hynek Schlawack <hs@ox.cx>
Summary
add
log()
toBoundLoggerFiltering*
to better matchBoundLogger
signaturePull Request Check List
typing_examples.py
(not actually new, just fixesstdlib.get_logger().log()
)docs/api.rst
by hand.versionadded
,versionchanged
, ordeprecated
directives.Find the appropriate next version in our
__init__.py
file..rst
and.md
files is written using semantic newlines.