fix: missing default borderRadius-xl #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hyoban
reviewed
May 10, 2024
| @@ -95,8 +95,9 @@ export function presetShadcn(options: PresetShadcnOptions = {}): Preset<Theme> { | |||
| }, | |||
| }, | |||
| borderRadius: { | |||
| lg: `var(--radius)`, | |||
| md: `calc(var(--radius) - 2px)`, | |||
| xl: 'calc(var(--radius) + 4px)', | |||
There was a problem hiding this comment.
I didn‘t see the shadcn document with the recommendation to set this line.
There was a problem hiding this comment.
Hi @hyoban, you can see the declarations here: https://github.com/search?q=repo%3Aradix-vue%2Fshadcn-vue%20calc(var(--radius)%20%2B%204px)&type=code
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh, It looks like the cli will generate this configuration
hyoban
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make quotes consistent