Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: android feature set #2

Merged
merged 10 commits into from
Jul 24, 2024
Merged

feat: android feature set #2

merged 10 commits into from
Jul 24, 2024

Conversation

hyochan
Copy link
Owner

@hyochan hyochan commented Jul 24, 2024

I have modified the linting and migrated the Android code from react-native-iap to the Expo module. So far, I have tested up to the purchase popup on ProductPurchase.

android.mp4

@hyochan hyochan added 🎯 feature New feature 🤖 android Related to android labels Jul 24, 2024
Copy link

github-actions bot commented Jul 24, 2024

Risk Level 2 - /home/runner/work/expo-iap/expo-iap/example/android/app/src/main/java/com/dooboolab/test/MainApplication.kt

  1. Ensure that the ReactNativeHostWrapper is correctly initialized and used.
  2. Verify that the application lifecycle methods are correctly overridden and called.

Risk Level 3 - /home/runner/work/expo-iap/expo-iap/src/modules/android.ts

  1. Ensure that sensitive data such as access tokens are not logged or exposed.
  2. Consider adding more detailed error handling for the validateReceiptAndroid method.

Risk Level 3 - /home/runner/work/expo-iap/expo-iap/android/src/main/java/expo/modules/iap/ExpoIapModule.kt

  1. Ensure that all exceptions are handled properly to avoid crashes. For example, throw Exception(\"getCurrentActivity returned null\") should be handled more gracefully.
  2. Consider adding more detailed logging for debugging purposes, especially in the onPurchasesUpdated method.
  3. Ensure that sensitive data such as purchase tokens are not logged or exposed.

🔍🛠️🔒


Powered by Code Review GPT

@hyochan hyochan merged commit 271d662 into main Jul 24, 2024
3 checks passed
@hyochan hyochan deleted the feat/android branch July 24, 2024 14:40
@hyochan hyochan restored the feat/android branch July 25, 2024 10:53
@hyochan hyochan deleted the feat/android branch July 25, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android Related to android 🎯 feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant