Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactoring - Move out default styles #68

Merged
merged 6 commits into from
Feb 15, 2019

Conversation

edTheGuy00
Copy link
Collaborator

@edTheGuy00 edTheGuy00 commented Feb 14, 2019

Moved out text styles to their own file, also changed from final to const. There's no need to assign them at runtime as they don't change. with const they will be assigned at compile time

as discussed in #67

@edTheGuy00 edTheGuy00 changed the title [WIP] Refactoring - Move out default styles [WIP] Refactoring - Move out default styles #67 Feb 14, 2019
@edTheGuy00 edTheGuy00 changed the title [WIP] Refactoring - Move out default styles #67 [WIP] Refactoring - Move out default styles Feb 14, 2019
@hyochan hyochan self-requested a review February 15, 2019 06:16
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@hyochan hyochan merged commit f9aa8ec into hyochan:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants