migrate billing to 5.0.0 #387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates to bumping billing? |
|
This PR is stale because it has been open 90 days with no activity. Leave a comment or this will be closed in 7 days |
hyochan
pushed a commit
that referenced
this pull request
Mar 7, 2023
This is build off of @youssefali424 #387 PR because that one had a couple issues. It didn't pass back the prices properly for items that were created in android billing 4.0 amongst other issues. I created two new dart objects that reflect android 5.0 billing objects `SubscriptionOffer` and `PricingPhase` that pass back all the information associated with a play store item, so you can navigate those to extract introductory offers and discounted subscriptions as opposed to just having a single offer price. I've also kept the `price`, `currency` and `localizedPrice` values and made them backwards compatible with items that were updated from billing 4.0 if your app relies on those (ours did) ~~Note that the tests fail because of ios and android receipt validation only, which appears to not point to a valid URL anymore.~~ All tests are passing and extra code coverage has been added Co-authored-by: youssefali424 <youssef4242014@gmail.com> Co-authored-by: Sam Bergeron <sam@cronometer.com>
JoyHong
pushed a commit
to JoyHong/flutter_inapp_purchase
that referenced
this pull request
Jul 6, 2023
This is build off of @youssefali424 hyochan#387 PR because that one had a couple issues. It didn't pass back the prices properly for items that were created in android billing 4.0 amongst other issues. I created two new dart objects that reflect android 5.0 billing objects `SubscriptionOffer` and `PricingPhase` that pass back all the information associated with a play store item, so you can navigate those to extract introductory offers and discounted subscriptions as opposed to just having a single offer price. I've also kept the `price`, `currency` and `localizedPrice` values and made them backwards compatible with items that were updated from billing 4.0 if your app relies on those (ours did) ~~Note that the tests fail because of ios and android receipt validation only, which appears to not point to a valid URL anymore.~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade billingclient to 5.0.0