Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add correct types for new method: requestPendingPurchasesIOS #690

Closed
jvandenaardweg opened this issue Sep 3, 2019 · 1 comment · Fixed by #693
Closed

Add correct types for new method: requestPendingPurchasesIOS #690

jvandenaardweg opened this issue Sep 3, 2019 · 1 comment · Fixed by #693
Labels
🤖 android Related to android 📱 iOS Related to iOS ❄️ types Typing issues

Comments

@jvandenaardweg
Copy link
Contributor

jvandenaardweg commented Sep 3, 2019 •
edited
Loading

Version of react-native-iap

3.4.2

Version of react-native

0.60.4

Platforms you faced the error (IOS or Android or both?)

both

Expected behavior

Typescript/Flow should get the correct types for requestPendingPurchasesIOS, introduced here: #663

Actual behavior

No types

Tested environment (Emulator? Real Device?)

IDE

Steps to reproduce the behavior

Use TS :-)
@hyochan hyochan added 🤖 android Related to android 📱 iOS Related to iOS ❄️ types Typing issues labels Sep 3, 2019
hyochan added a commit that referenced this issue Sep 4, 2019
@hyochan
Fixes #690
79ad95d
@hyochan hyochan mentioned this issue Sep 4, 2019
Merged
@hyochan
Copy link
Owner

hyochan commented Sep 4, 2019

@jvandenaardweg Thanks for the issue. However, requestPendingPurchasesIOS has been renamed to getPendingPurchasesIOS and there is actually type definition for typescript but not flow. I've updated flow in #693.

hyochan added a commit that referenced this issue Sep 4, 2019
@hyochan
Fixes #690
9fd350b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤖 android Related to android 📱 iOS Related to iOS ❄️ types Typing issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

release/3.4.3 hyochan/react-native-iap
2 participants
@jvandenaardweg @hyochan