Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: purchases.md use object instead of params in requestSubscription call #2459

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

frothAml
Copy link
Contributor

@frothAml frothAml commented Jun 14, 2023

The example shown in purchases.md has the wrong interface use for the function requestSubscription

In the docs example is shown as

      await requestSubscription(
        {sku},
        ...(offerToken && {subscriptionOffers: [{sku, offerToken}]}),
      );

While the interface to the function requires an object of the type RequestSubscription and not 2 args

@hyochan hyochan added the 📖 documentation Improvements or additions to documentation label Jun 22, 2023
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hyochan hyochan merged commit 910ef24 into hyochan:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants