Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added missing iOS appAccountToken on ProductPurchase TS interface #2506

Merged
merged 1 commit into from
Aug 13, 2023
Merged

fix: added missing iOS appAccountToken on ProductPurchase TS interface #2506

merged 1 commit into from
Aug 13, 2023

Conversation

quentinnippert
Copy link
Contributor

Fixing issue #2434

@hyochan hyochan added 📱 iOS Related to iOS ❄️ types Typing issues labels Aug 6, 2023
hyochan
hyochan requested changes Aug 6, 2023
View reviewed changes
Copy link
Owner

@hyochan hyochan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you kindly check the CI failing?

@quentinnippert
Copy link
Contributor Author

Could you kindly check the CI failing?

@hyochan It failed on the "Verify no files have changed after auto-fix" script. I think this is normal behavior since I added a property to the transactionSk2ToPurchaseMap method parameter and to the ProductPurchase interface. Am I right?

hyochan
hyochan approved these changes Aug 13, 2023
View reviewed changes
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are right! I just removed the auto-fix step in CI for the next changes.

Thanks for your contribution!

@hyochan hyochan merged commit be274b5 into hyochan:main Aug 13, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyochan hyochan hyochan approved these changes

Assignees
No one assigned
Labels
📱 iOS Related to iOS ❄️ types Typing issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quentinnippert @hyochan @quentinNpApnl