Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update appleSk2.ts #2608

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Update appleSk2.ts #2608

merged 2 commits into from
Dec 8, 2023

Conversation

isnolan
Copy link
Contributor

@isnolan isnolan commented Nov 12, 2023

fixed issue for #2607 #2461

fixed issue for #2607
@hyochan hyochan added the 📱 iOS Related to iOS label Nov 12, 2023
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you kindly check on the CI failing?

@isnolan
Copy link
Contributor Author

isnolan commented Nov 13, 2023

Yes, I have checked the code changes and it solved the problem I encountered very well. However, the manifest shows that I only changed one JS code and the CI failure occurred in the swift code, which is beyond my knowledge. I would be very grateful if I could get some help from you.

@cervebar
Copy link
Contributor

Yes, I have checked the code changes and it solved the problem I encountered very well. However, the manifest shows that I only changed one JS code and the CI failure occurred in the swift code, which is beyond my knowledge. I would be very grateful if I could get some help from you.​

I think it's just because of swift linter, install this on your Mac - https://github.com/realm/SwiftLint and run swiftlint lint --fix --format --path ios/*.swift --config .swiftlint.yml

@isnolan
Copy link
Contributor Author

isnolan commented Nov 19, 2023

@cervebar It was you who helped me take the first step in swift, thank you very much!

@harbolaez
Copy link

Any update on this? thanks!

@isnolan
Copy link
Contributor Author

isnolan commented Nov 24, 2023

I'm also looking forward to merging the code. @hyochan

Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hyochan hyochan merged commit de8a854 into hyochan:main Dec 8, 2023
3 checks passed
arthurgeron pushed a commit to arthurgeron/react-native-iap that referenced this pull request Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📱 iOS Related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants