fix gh action if statements (HDFGroup#3213)

hyoklee · Jun 30, 2023 · 4cf8bb2 · 4cf8bb2
1 parent 9b3feed
commit 4cf8bb2
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/.github/workflows/tarball.yml b/.github/workflows/tarball.yml
@@ -77,7 +77,7 @@ jobs:
     name: Create a source tarball
     runs-on: ubuntu-latest
     needs: check_commits
-    if: ('${{ inputs.use_environ }}' == 'snapshots' && ${{ needs.check_commits.outputs.has_changes }} == 'true') || '${{ inputs.use_environ }}' == 'release'
+    if: ${{ ((inputs.use_environ == 'snapshots') && (needs.check_commits.outputs.has_changes == 'true')) || (inputs.use_environ  == 'release') }}
     outputs:
       file_base: ${{ steps.set-file-base.outputs.FILE_BASE }}
     steps:
@@ -101,7 +101,7 @@ jobs:
       - name: Set file base name
         id: set-file-base
         run: |
-          if [[ '${{ inputs.use_environ }}' == 'snapshots' && ${{ needs.check_commits.outputs.has_changes }} == 'true' ]]
+          if [[ '${{ inputs.use_environ }}' == 'snapshots' && '${{ needs.check_commits.outputs.has_changes }}' == 'true' ]]
           then
             FILE_NAME_BASE=$(echo "hdf5-${{ needs.check_commits.outputs.branch_ref }}-${{ needs.check_commits.outputs.branch_sha }}")
           else
@@ -112,15 +112,15 @@ jobs:
 
       - name: Create snapshot file base name
         id: create-file-base
-        if: ${{ inputs.use_environ }} == 'snapshots' && ${{ needs.check_commits.outputs.has_changes }} == 'true'
+        if: ${{ (inputs.use_environ == 'snapshots') && (needs.check_commits.outputs.has_changes == 'true') }}
         run: |
           cd "$GITHUB_WORKSPACE/hdfsrc"
           bin/bbrelease -d $GITHUB_WORKSPACE --branch ${{ needs.check_commits.outputs.branch_ref }} --revision gzip zip
         shell: bash
 
       - name: Create release file base name
         id: create-rel-base
-        if: ${{ inputs.use_environ }} == 'release'
+        if: ${{ (inputs.use_environ == 'release') }}
         run: |
           cd "$GITHUB_WORKSPACE/hdfsrc"
           bin/release -d $GITHUB_WORKSPACE gzip zip cmake-tgz cmake-zip