Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and stream the People. #157

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Update and stream the People. #157

merged 2 commits into from
Nov 9, 2023

Conversation

ikeough
Copy link
Contributor

@ikeough ikeough commented Nov 9, 2023

The people function was never published. This PR updates the function to latest and adds streaming.

Building Blocks contains many functions that are used in Hypar examples and in the Hypar tour. Please ensure that that following are true before granting this PR.

  • The function has been published with staging, (but not released, until this PR is approved).
  • The function has been tested against the tour. If the function is not used in the tour, mark this as not applicable (NA).
  • Strings in hypar.json have been translated to supported languages in the messages field.
  • Any new project added to this repository has been added to BuildingBlocks.sln.

This change is Reviewable

@ikeough ikeough requested a review from a team as a code owner November 9, 2023 20:36
Copy link
Contributor

@anthonie-kramer anthonie-kramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ikeough)

@ikeough ikeough merged commit 9e8fb2d into master Nov 9, 2023
2 checks passed
@ikeough ikeough deleted the people branch November 9, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants