Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rendered evaluations fetching and styles in hypercerts view page #328

Merged
merged 12 commits into from
Dec 21, 2024

Conversation

bitbeckers
Copy link
Contributor

  • Cleans up path invalidation method into single method in app/actions dir
  • Updates evaluation fetching to wrapper component with paginated fetching
  • Updates card styling to be more efficient with screen real estate
  • Cleans up pagination components that are now also used for evaluations

For review, the following hypercertID has enough attestations to demo the impact of the changes: 11155111-0xa16DFb32Eb140a6f3F2AC68f41dAd8c7e83C4941-254871492823782909134067580966394390380544

@bitbeckers bitbeckers added the enhancement New feature or request label Dec 19, 2024
@bitbeckers bitbeckers self-assigned this Dec 19, 2024
Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hypercerts-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2024 1:23pm

@bitbeckers bitbeckers changed the title Feat/evaluation fetcher flow hypercert view Update rendered evaluations fetching and styles in hypercerts view page Dec 19, 2024
@holkexyz
Copy link
Member

holkexyz commented Dec 20, 2024

1. Organization of boxes

Depending on the window size, I'm getting 2 rows with the second row having a lot of white space:
image

I think it would be great to limit it to one row and show only as many as fit in one row, but I guess that might be a bit complicated.

Maybe an alternative is the horizontal scrolling that Shu implemented for the self-reports? i.e. instead of the pagination, the user can scroll through additional evaluations.

2. Design of boxes

There is a lot of white space, when the comments are short. I assume that it is the easiest to have a set height and width. I think we can increase the width to 320px (from 280px, if I see it correctly). And allow only for about 2 lines of text. If the text is longer, the button "show full comment" is shown. If it is clicked, the box height increases to show the full comment (up to 280 characters). It is ok, if all boxes increase in height, when the button on one is clicked.

Currently there is a lot of space between the button and the text, which with the above changes shouldn't be there:
image

@bitbeckers
Copy link
Contributor Author

@holkexyz updated based on your comments. I'm meeting with Shu on Tuesday and we can pick the best of both implementations and align on it.

Screenshot 2024-12-21 at 14 20 50

@bitbeckers bitbeckers merged commit a6767e2 into dev Dec 21, 2024
2 checks passed
@bitbeckers bitbeckers deleted the feat/evaluation_fetcher_flow_hypercert_view branch December 21, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants