Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show exception log properties #472

Merged
merged 1 commit into from
Jul 15, 2024
Merged

fix: Show exception log properties #472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/app/src/LogSidePanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1399,7 +1399,13 @@ function PropertySubpanel({
!key.startsWith('otel.library.') &&
!key.startsWith('telemetry.') &&
!key.startsWith('hyperdx.') &&
!key.startsWith('exception.') &&
// We need to show exception properties if it's an exception log, which
// has exception.* at the top-level. We're using the existence of span events as a
// proxy for this behavior for now.
!(
key.startsWith('exception.') &&
getLogProperty(logData, '__events') != null
) &&
!(key.startsWith('http.request.header.') && isNetworkReq) &&
!(key.startsWith('http.response.header.') && isNetworkReq) &&
key != '__events' &&
Expand Down
Loading