Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-group-by support for event charts #474

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

MikeShi42
Copy link
Contributor

  • use multi field selector for group by in event charts (we need to follow up w/ metrics, but that requires a new selector component)
  • fixed a bug where multi-group-by requires same data type properties for events.
  • fixed a bug where chart edit form will do excess re-rendering due to non-memo value passed into useDebounce
  • fixed a regression where if a chart is in the error state, it'll be stuck with an error message even if the chart config changes to a valid one

Copy link

changeset-bot bot commented Jul 15, 2024

⚠️ No Changeset found

Latest commit: d3eb062

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kodiakhq kodiakhq bot merged commit 0be2d25 into main Jul 16, 2024
4 checks passed
@kodiakhq kodiakhq bot deleted the mikeshi/event-chart-multi-group-by branch July 16, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants